Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network field from CardanoDbBeacon #1957

Open
7 tasks
jpraynaud opened this issue Sep 26, 2024 · 0 comments
Open
7 tasks

Remove network field from CardanoDbBeacon #1957

jpraynaud opened this issue Sep 26, 2024 · 0 comments
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

Why

The CardanoDbBeacon holds a network field which should be removed as this information is not necessary to operate the Mithril network.

What

Remove the network field in the CardanoDbBeacon without breaking-change.

How

  • Adapt the computation of the hash in the compute_hash of the CardanoImmutableDigester to retrieve the network value:
    • from the configuration in the signer
    • from the configuration in the aggregator
    • from the certificate metadata in the client
    • Golden test the computation of the digest to make sure there is no breaking change
  • Remove the network field in the CardanoDbBeacon
  • ⚠️ Recompute certificate chain to be scheduled with next distribution
@jpraynaud jpraynaud added the refactoring 🛠️ Code refactoring and enhancements label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

No branches or pull requests

1 participant