Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make epoch non optional in RegisterSignerMessage #1956

Closed
1 of 2 tasks
jpraynaud opened this issue Sep 26, 2024 · 0 comments · Fixed by #1986
Closed
1 of 2 tasks

Make epoch non optional in RegisterSignerMessage #1956

jpraynaud opened this issue Sep 26, 2024 · 0 comments · Fixed by #1986
Assignees
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Sep 26, 2024

Why

The epoch field of the RegisterSignerMessage is optional but sent by all the signers from distribution 2318. We want to make it non optional.

Note

The signer version released with 2318 distribution is 0.2.36 which is not run any more by any signer in the release-mainnet network. Thus it is not considered as a breaking-change.

What

Make the epoch field non optional in RegisterSignerMessage (marked by era_deprecate!("make epoch of RegisterSignerMessage not optional"); in the code.

How

  • Make the epoch field non optional in RegisterSignerMessage
  • Update the patch version of the Open API specification
@jpraynaud jpraynaud added the refactoring 🛠️ Code refactoring and enhancements label Sep 26, 2024
@Alenar Alenar self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants