Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregator advertises constant signing configurations for an epoch #1924

Closed
6 tasks done
Tracked by #1777
jpraynaud opened this issue Sep 9, 2024 · 0 comments · Fixed by #1964
Closed
6 tasks done
Tracked by #1777

Aggregator advertises constant signing configurations for an epoch #1924

jpraynaud opened this issue Sep 9, 2024 · 0 comments · Fixed by #1964
Assignees
@sfauvel @dlachaume
Labels
feature 🚀 New implemented feature

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Sep 9, 2024 •
edited by dlachaume
Loading

Why

We need the signing configurations advertised by the /epoch-settings route to be constant for an epoch.

What

Record the signing configurations one epoch in advance in the aggregator.

How

  • Refactor EpochSettings namings
  • Rework EpochSettingsStorer to handle the new AggregatorEpochSettings structure, which will contain the signing configurations
  • Store signing configurations in the epoch_settings table
  • Record the signing configurations when the aggregator starts
  • Record the signing configurations when transitioning to a new epoch
  • Use the signing configurations recorded at the previous epoch in the cardano_transactions_signing_config and next_cardano_transactions_signing_config fields of the /epoch-settings/ route
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfauvel sfauvel

@dlachaume dlachaume

Labels
feature 🚀 New implemented feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make aggregator advertises constant signing configurations for an epoch input-output-hk/mithril
3 participants
@sfauvel @jpraynaud @dlachaume