Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-5930: Add dependencies needed for e2e tests. #37

Open
wants to merge 1 commit into
base: PLT-5884/e2e-tests
Choose a base branch
from

Conversation

shlevy
Copy link
Collaborator

@shlevy shlevy commented Jun 3, 2023

Note that tests now fail with:

Error: ENOENT: no such file or directory, scandir '/home/shlevy/src/iog/marlowe-playground/e2e/config/mappings/fixtures/'

and later

/home/shlevy/src/iog/marlowe-playground/e2e/node_modules/cucumber-html-reporter/lib/hierarchyReporter.js:20
suite.features.forEach(function (feature) {
^
TypeError: suite.features.forEach is not a function

@shlevy shlevy added the No Changelog Required Turns of the check-changelog check label Jun 3, 2023
@ladamesny
Copy link
Collaborator

hey @shlevy thanks for working on this. I just rebased your branch with the tests I'm working on. I tried running the tests with firefox and webkit and I got the following message:

   browserType.launch: Executable doesn't exist at /nix/store/vqz7samp6r3c532cnxjhqwwl96n7w1px-playwright-browsers/webkit-1837/pw_run.sh
   
   ║ Looks like Playwright Test or Playwright was just installed or updated. ║
   ║ Please run the following command to download new browsers:              ║
   ║                                                                         ║
   ║     npx playwright install                                              ║
   ║                                                                         ║
   ║ <3 Playwright Team             

I then ran "npx playwright install" and it was just hanging.

To set the browser, change the UI_AUTOMATION_BROWSER env variable in e2e/env/common.env to 'firefox' or 'webkit' and then run . ./run_tests.sh wip from the e2e folder.

Chromium still works for me locally.

@shlevy
Copy link
Collaborator Author

shlevy commented Jun 4, 2023

@ladamesny I'm unable to test any further due to the errors shared above (which are still there after rebase)

@ladamesny
Copy link
Collaborator

Hi @shlevy I just removed references to fixtures from the code. That first error indicates that it can't find the folder '/home/shlevy/src/iog/marlowe-playground/e2e/config/mappings/fixtures/', which is weird because the folder was checked in.

The second error message usually means that it can't find the **.features files, which is also checked in and should be under '/home/shlevy/src/iog/marlowe-playground/e2e/src/features/*'.

Do you want to look at it together on Monday? Feels like this should be easy to resolve together. Thanks!

@shlevy
Copy link
Collaborator Author

shlevy commented Jun 5, 2023

I'm not available to meet today or tomorrow, I might have time Wednesday and I'll definitely have time Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Turns of the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants