Draft: update nodejs from 14 to 18 #28
Conversation
hrajchert
force-pushed
the
hrajchert/fix-node-deps
branch
from
19a3077
to
e90e0d2
Compare
| @@ -17,15 +17,14 @@ | |||
| "dependencies": { | |||
| "@fortawesome/fontawesome-free": "^5.10.2", | |||
| "@popperjs/core": "^2.9.2", | |||
| "big-integer": "^1.6.50", | |||
| "bignumber": "^1.1.0", | |||
There was a problem hiding this comment.
we should eventually remove the bignumber library as there is a Browser default since 2020. This would require modifications in several places though.
| "monaco-editor": "^0.22.3", | ||
| "monaco-emacs": "^0.2.2", | ||
| "monaco-vim": "^0.1.7", | ||
| "monaco-editor": "^0.38.0", |
There was a problem hiding this comment.
Monaco editor didn't bring too much trouble that I could tell, just some codeAction changes
| "bignumber": "^1.1.0", | ||
| "blockly": "^4.20201217.0", | ||
| "blockly": "^9.3.3", |
There was a problem hiding this comment.
Blockly has been heavily refactored since the 4th quarter 2020 release. Among other it is undergoing a TypeScript migration https://github.com/google/blockly/releases
| "monaco-emacs": "^0.3.0", | ||
| "monaco-vim": "^0.3.5", |
There was a problem hiding this comment.
I think we should remove these in the future and the Editor mode selector... it is confusing, and something more in line with a "full IDE"... better to use vim, emacs, or vscode directly
| @@ -17,15 +17,14 @@ | |||
| "dependencies": { | |||
There was a problem hiding this comment.
Most of these changes were required to eliminate the npm audit warnings or even to allow npm install to work
| @@ -0,0 +1,23 @@ | |||
| import { BlockBase, BlockCreate, BlockChange } from "blockly/core/events/events"; | |||
There was a problem hiding this comment.
This is a helper file for the Blockly types, as we are importing Blockly dynamically. We should revisit this approach
This PR updates nodejs and other dependencies to avoid hanging for a long time while doing
npm ci.It is a Draft until the following issues are fixed:
Pre-submit checklist: