Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial brand support #431

Merged
merged 12 commits into from
May 7, 2024
Merged

Conversation

coire1
Copy link
Contributor

@coire1 coire1 commented Apr 17, 2024

Description

This PR introduces the BrandBloc, a Bloc responsible for managing the brand state and the catalyst_voices_brands package, a package the contains all possible brands and related Theme and the ThemeBuilder utility.

Related Issue(s)

Closes #411

Screenshots

ifr-2024-04-16_19.02.07.mp4

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@coire1 coire1 self-assigned this Apr 17, 2024
Copy link
Contributor

github-actions bot commented Apr 17, 2024

Test Report | ${\color{lightgreen}Pass: 48/48}$ | ${\color{red}Fail: 0/48}$ |

@coire1 coire1 marked this pull request as ready for review April 17, 2024 09:07
@coire1 coire1 requested a review from minikin as a code owner April 17, 2024 09:07
@coire1 coire1 requested a review from dtscalac April 17, 2024 09:07
@coire1 coire1 added the review me PR is ready for review label Apr 17, 2024
@coire1 coire1 marked this pull request as draft May 6, 2024 08:45
@coire1 coire1 removed the review me PR is ready for review label May 6, 2024
@minikin minikin added the do not merge yet PR is not ready to be merged yet label May 6, 2024
@coire1 coire1 marked this pull request as ready for review May 6, 2024 15:16
@coire1 coire1 added review me PR is ready for review and removed do not merge yet PR is not ready to be merged yet labels May 6, 2024
@minikin minikin enabled auto-merge (squash) May 7, 2024 07:59
@minikin minikin self-requested a review May 7, 2024 08:00
@minikin minikin merged commit bfec640 into main May 7, 2024
30 checks passed
@minikin minikin deleted the feat/add-initial-brand-support branch May 7, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add initial brands support
3 participants