Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ [TASK] : Remove expect() from the upstream Scylla crates FromRow derived macro #828

Open
stevenj opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@stevenj
Copy link
Collaborator

stevenj commented Sep 17, 2024

Summary

Fix the upstream FromRow derived macro to not use expect.

Description

The Scylla Rust crate has expect() inside the derived macro FromRow.
It is possible for that function to return an error, which it should do rather than panic.
This task is to fix the macro to return an error, and not panic.
Then remove the #[allow(clippy::expect_used)] lint allowances from Catalyst gateway that were added to get a clean compilation.

@stevenj stevenj added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 17, 2024
@stevenj stevenj changed the title 🛠️ [TASK] : Remove Expect from the upstream scyla FromRow derived macro 🛠️ [TASK] : Remove expect() from the upstream Scylla crates FromRow derived macro Sep 17, 2024
@Mr-Leshiy Mr-Leshiy self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants