Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update fund11 event db data | NPG-000 #612

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Oct 31, 2023

Description

First draft of fund11 params for event-db

Fixes # (issue) if applicable

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration: if applicable

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

List of new dependencies: if applicable

Provide a list of newly added dependencies in this PR, with the description of what are they doing and why do we need them.

  • Crate A: description
  • Crate B: description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kukkok3 kukkok3 self-assigned this Oct 31, 2023
@kukkok3 kukkok3 added the review me PR is ready for review label Oct 31, 2023
FelipeRosa
FelipeRosa previously approved these changes Oct 31, 2023
Copy link
Contributor

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmgilman
Copy link
Collaborator

jmgilman commented Nov 2, 2023

LGTM. Let me merge this, because I want to update the CI first.

@jmgilman jmgilman merged commit cedc168 into main Nov 2, 2023
26 of 27 checks passed
@jmgilman jmgilman deleted the fund11-eventdb-params branch November 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants