Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Proposal score calculation, add rounding to 1 decimal place | NPG-8046 #611

Merged
merged 2 commits into from
Nov 1, 2023
Merged

feat: Proposal score calculation, add rounding to 1 decimal place | NPG-8046 #611

merged 2 commits into from
Nov 1, 2023

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Oct 31, 2023 •
edited
Loading

Description

Updated proposal community score calculation, add rounding to 1 decimal place.
So now with the previous calculation result is 5.799999999999999 it will be rounded to 5.8,
and if result is 5.449999999999999 to 5.4.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • weighted_score_test_2
  • weighted_score_test_3

@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Oct 31, 2023
@Mr-Leshiy Mr-Leshiy self-assigned this Oct 31, 2023
@Mr-Leshiy Mr-Leshiy linked an issue Oct 31, 2023 that may be closed by this pull request
Perform community review score rounding on the backend #595
Closed
@Mr-Leshiy Mr-Leshiy changed the title feat: Proposal score calculation, add rounding to 1 decimal place feat: Proposal score calculation, add rounding to 1 decimal place | NPG-8046 Oct 31, 2023
saibatizoku
saibatizoku approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mr-Leshiy Mr-Leshiy merged commit 4a2dc7a into main Nov 1, 2023
27 of 28 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feature/proposal-score-rounding branch November 1, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saibatizoku saibatizoku saibatizoku approved these changes

@stevenj stevenj Awaiting requested review from stevenj

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

@minikin minikin Awaiting requested review from minikin

@kukkok3 kukkok3 Awaiting requested review from kukkok3

Assignees

@Mr-Leshiy Mr-Leshiy

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform community review score rounding on the backend
2 participants
@Mr-Leshiy @saibatizoku