Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(catalyst-toolbox): Adds loadtest snapshot processing feature. | NPG-0000 #567

Merged
merged 18 commits into from
Nov 22, 2023
Merged

feat(catalyst-toolbox): Adds loadtest snapshot processing feature. | NPG-0000 #567

merged 18 commits into from
Nov 22, 2023

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Sep 16, 2023

This change adds the ability to auto-generate snapshot data for automated loadtests from real snapshot data.
It also:

  • makes a snapshot artifact file compatible with Vit-SS.
  • adds snapshot report and configuration data to the main snapshot file.
  • Keeps voters who are underpower, but flags them.
  • Sorts both files so they always produce consistent output (helps check for difference run to run).
  • Fix consistency with output fields (Hex fields all have "0x" on the front.

All of this was needed for loadtest purposes, which is why its all in the same PR rather than a series of PR's.
This may require some modification to scripts which consume the snapshot report due to the changes.

@minikin minikin added the review me PR is ready for review label Sep 18, 2023
cong-or
cong-or previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin enabled auto-merge (squash) September 20, 2023 11:20
minikin
minikin previously approved these changes Sep 20, 2023
View reviewed changes
minikin and others added 2 commits September 27, 2023 09:29
@minikin
Merge branch 'main' into loadtest-snapshot
8d631b6
@saibatizoku
fix: broken tests
90dae10 
Repairs broken tests, disables test for dreps rewards until
specs are revisited
@minikin minikin self-requested a review November 20, 2023 11:09
minikin
minikin previously approved these changes Nov 20, 2023
View reviewed changes
Mr-Leshiy
Mr-Leshiy previously approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy
Copy link
Contributor

@stevenj are we going to merge this branch ?

@stevenj stevenj dismissed stale reviews from Mr-Leshiy and minikin via 7dbc445 November 21, 2023 13:10
@kukkok3 kukkok3 self-requested a review November 22, 2023 11:44
kukkok3
kukkok3 previously approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cong-or
cong-or approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit 8e5b9bd into main Nov 22, 2023
58 checks passed
@minikin minikin deleted the loadtest-snapshot branch November 22, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cong-or cong-or cong-or approved these changes

@minikin minikin minikin left review comments

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

@kukkok3 kukkok3 kukkok3 left review comments

@saibatizoku saibatizoku Awaiting requested review from saibatizoku

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa

Assignees

@stevenj stevenj

Labels
review me PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stevenj @Mr-Leshiy @minikin @cong-or @kukkok3 @saibatizoku