From 6a209a2904826204e9066929bb68a56a5581b9ea Mon Sep 17 00:00:00 2001
From: Thiago Cardoso <thiago.figueredo@incognia.com>
Date: Mon, 15 Jul 2024 20:41:58 -0300
Subject: [PATCH] fix: allow occurred_at to be omitted on RegisterFeedback

This field is optional, should not be enforced.
---
 incognia.go      |  3 ---
 incognia_test.go | 13 ++-----------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/incognia.go b/incognia.go
index d502a54..20db323 100644
--- a/incognia.go
+++ b/incognia.go
@@ -248,9 +248,6 @@ func (c *Client) registerFeedback(feedbackEvent FeedbackType, occurredAt *time.T
 	if !isValidFeedbackType(feedbackEvent) {
 		return ErrInvalidFeedbackType
 	}
-	if occurredAt == nil {
-		return ErrMissingTimestamp
-	}
 
 	requestBody := postFeedbackRequestBody{
 		Event:      feedbackEvent,
diff --git a/incognia_test.go b/incognia_test.go
index 3617dc9..1ca7d11 100644
--- a/incognia_test.go
+++ b/incognia_test.go
@@ -118,8 +118,7 @@ var (
 		ExternalID:     "some-external-id",
 	}
 	postFeedbackRequestBodyRequiredFieldsFixture = &postFeedbackRequestBody{
-		Event:      SignupAccepted,
-		OccurredAt: &now,
+		Event: SignupAccepted,
 	}
 	feedbackIdentifiersFixture = &FeedbackIdentifiers{
 		InstallationID: "some-installation-id",
@@ -637,7 +636,7 @@ func (suite *IncogniaTestSuite) TestSuccessRegisterFeedbackNilOptional() {
 	feedbackServer := suite.mockFeedbackEndpoint(token, postFeedbackRequestBodyRequiredFieldsFixture)
 	defer feedbackServer.Close()
 
-	err := suite.client.RegisterFeedback(postFeedbackRequestBodyRequiredFieldsFixture.Event, postFeedbackRequestBodyRequiredFieldsFixture.OccurredAt, nil)
+	err := suite.client.RegisterFeedback(postFeedbackRequestBodyRequiredFieldsFixture.Event, nil, nil)
 	suite.NoError(err)
 }
 
@@ -671,14 +670,6 @@ func (suite *IncogniaTestSuite) TestErrorRegisterFeedbackInvalidFeedbackType() {
 	suite.EqualError(err, ErrInvalidFeedbackType.Error())
 }
 
-func (suite *IncogniaTestSuite) TestErrorRegisterFeedbackNilTimestamp() {
-	feedbackServer := suite.mockFeedbackEndpoint(token, postFeedbackRequestBodyFixture)
-	defer feedbackServer.Close()
-
-	err := suite.client.RegisterFeedback(postFeedbackRequestBodyFixture.Event, nil, feedbackIdentifiersFixture)
-	suite.EqualError(err, ErrMissingTimestamp.Error())
-}
-
 func (suite *IncogniaTestSuite) TestErrorsRegisterFeedback() {
 	errors := []int{http.StatusBadRequest, http.StatusInternalServerError}
 	for _, status := range errors {