Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy job not marked as failed after Number Of Attempts is reached. #101

Open
vandem9 opened this issue Nov 19, 2020 · 1 comment
Open

Comments

@vandem9
Copy link

vandem9 commented Nov 19, 2020

When you check the 'Ensure Health is Green after deploy?' checkbox and give a number of max attempts, the job does not fail when the environment is not green after the max attempts. It just finishes successfully.

Versions reported: (current: c6394239f86b8d3816aafc8460608cf3d7737249-jenkins-xxxx-xxx-xxx-web-dev-app-232, underDeployment: 22875bd2b9f1378f81705d79c11158fe8a00f4d5-jenkins-xxxx-xxx-xxx-web-dev-app-234). Should I move on? false Checking health/status of environmentId e-adxak5zcm4 attempt 30/30 Versions reported: (current: c6394239f86b8d3816aafc8460608cf3d7737249-jenkins-xxxx-xxx-xxx-web-dev-app-232, underDeployment: 22875bd2b9f1378f81705d79c11158fe8a00f4d5-jenkins-xxxx-xxx-xxx-web-dev-app-234). Should I move on? false Environment Update timed-out. Aborting. Cleaning up temporary file /tmp/awseb-4915063107788028349.zip Finished: SUCCESS

@gdelisle
Copy link

I am seeing the same thing when the health is green. If the environment update timed out for whatever reason, and the plugin aborts, then the code was not updated and the deployment was a failure. This should fail the job result.
Checking health/status of environmentId e-ggmk9szymd attempt 30/30 Versions reported: (current: jenkins-xxx-deploy-to-prod-108-481f81072be1fc7972a28b8387935b9fe023d5be, underDeployment: jenkins-xxx-deploy-to-prod-109-ad113532df30d734095ae8683de82af1716d48bc). Should I move on? false Environment Update timed-out. Aborting. Cleaning up temporary file /cul/app/tomcat/xxx.xxx/temp/awseb-2516313202524385847.zip
The above resulted in a SUCCESS when it should result in a FAILURE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants