Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies with WoE #89

Open
2 tasks
sbjelogr opened this issue Jan 12, 2023 · 2 comments
Open
2 tasks

Fix inconsistencies with WoE #89

sbjelogr opened this issue Jan 12, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@sbjelogr
Copy link
Collaborator

After the changes related to the WoEEncoder in #53 , there are still parts of the package that rely on the "old" calculation of WoE.
Namely, this refers to the functions in

scorecard.metrics.metrics

that are also used in the reporting functionality for IV, PSI etc.

Ideally, one would like that the WoE is calculated via the WOEEncoder everywhere, to avoid potential inconsistencies.

Update to the documentation might be needed as well. Check:

  • howto/psi_and_iv.ipynb
  • howto/Optimizations.ipynb
@sbjelogr sbjelogr added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 12, 2023
@dlaprins
Copy link

Related: the IV-score in bucket_table() has a negative sign, as it depends on the sign of WoE which was altered. This might be unintuitive and should probably be changed. (credit to Mara de Rosa for finding the issue)

@josecaloca
Copy link

I have noticed that the WoE calculations from bucket_table method are not consistent with the WoeEncoder(). I believe these calculations should be consistent as they might mislead analyses.

discrepancies WOE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants