From a168a6dcdb6f5e3190b1e26e078621f64611a802 Mon Sep 17 00:00:00 2001 From: Gabriela Moreira Date: Fri, 18 Aug 2023 18:07:25 -0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Thomas Pani --- quint/src/ir/IRTransformer.ts | 2 +- quint/src/ir/IRprinting.ts | 4 ++-- quint/src/names/base.ts | 4 ++-- quint/test/builders/ir.ts | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/quint/src/ir/IRTransformer.ts b/quint/src/ir/IRTransformer.ts index c471514d6..a451cb60f 100644 --- a/quint/src/ir/IRTransformer.ts +++ b/quint/src/ir/IRTransformer.ts @@ -274,7 +274,7 @@ export function transformType(transformer: IRTransformer, type: t.QuintType): t. } /** - * Transforms a Quint declaration with a transformer, invoking the correspondent function for each + * Transforms a Quint declaration with a transformer, invoking the corresponding function for each * inner component. * * @param transformer: the IRTransformer instance with the functions to be invoked diff --git a/quint/src/ir/IRprinting.ts b/quint/src/ir/IRprinting.ts index 961614588..76315910c 100644 --- a/quint/src/ir/IRprinting.ts +++ b/quint/src/ir/IRprinting.ts @@ -31,8 +31,8 @@ export function moduleToString(quintModule: QuintModule): string { /** * Pretty prints a declaration. Includes a type annotation if the definition is - * annotated, or if a type is provided. The annotation is preferred over the - * type. + * annotated, or if a type is provided. A type annotation, if present, takes + * precedence over a type provided as argument to this function. * * @param decl the Quint declaration to be formatted * @param includeBody optional, whether to include the body of the declaration, diff --git a/quint/src/names/base.ts b/quint/src/names/base.ts index 0fa174166..66bf994e4 100644 --- a/quint/src/names/base.ts +++ b/quint/src/names/base.ts @@ -38,10 +38,10 @@ export type Definition = (QuintDef | ({ kind: 'param' } & QuintLambdaParameter)) hidden?: boolean /* `namespaces` are names to add to the definition's name, when it * is copied from one module to another with a qualified name. Ordered from - * innermost to the outtermost. */ + * innermost to the outermost namespace. */ namespaces?: string[] /* importedFrom` is a reference to the import/instance/export statement that - * originated the definition, when the definition was copied from another + * originated the definition, if the definition was copied from another * module. */ importedFrom?: QuintImport | QuintInstance | QuintExport /* `typeAnnotation` is the type annotation of the definition, if it has one. diff --git a/quint/test/builders/ir.ts b/quint/test/builders/ir.ts index b6480eabc..6ba966c3a 100644 --- a/quint/test/builders/ir.ts +++ b/quint/test/builders/ir.ts @@ -39,7 +39,7 @@ export function buildDef(def: string): QuintDef { const quintModule = buildModuleWithDecls([def]) const decl = quintModule.declarations[0] if (!isDef(decl)) { - throw new Error(`Error trying to build def from declaration that is not a def - ${JSONbig.stringify(decl)}`) + throw new Error(`Error trying to build def from declaration that is not a def: ${JSONbig.stringify(decl)}`) } return decl }