Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAL in use after it has bee deprecated #15848

Closed
przemas75 opened this issue Sep 5, 2024 · 2 comments
Closed

ADAL in use after it has bee deprecated #15848

przemas75 opened this issue Sep 5, 2024 · 2 comments
Labels
bug unexpected problem or unintended behavior waiting for response waiting for response from contributor

Comments

@przemas75
Copy link

Relevant telegraf.conf

none

Logs from Telegraf

none

System info

Telegraf 1.31.3 all

Docker

No response

Steps to reproduce

  1. github.com/Azure/go-autorest/autorest/adal v0.9.23

...

Expected behavior

Removal of this dependency. MSAL is already included.

Actual behavior

ADAL stil in place.

Additional info

I can't find any info regarding ADAL removal, since it was deprecated like a year ago:
https://learn.microsoft.com/en-us/entra/identity-platform/msal-migration

@przemas75 przemas75 added the bug unexpected problem or unintended behavior label Sep 5, 2024
@DStrand1 DStrand1 self-assigned this Sep 5, 2024
@srebhan
Copy link
Member

srebhan commented Sep 10, 2024

@przemas75 can we be sure this will not work with any of the Azure instances out there anymore? Citing from the page you linked:

While existing apps that use ADAL will continue to work, Microsoft will no longer release security fixes on ADAL.

So removing this would likely break those existing apps, won't it? How about adding the new mechanism and print a warning if someone chooses to use ADAL?

@srebhan srebhan added the waiting for response waiting for response from contributor label Sep 10, 2024
@telegraf-tiger
Copy link
Contributor

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior waiting for response waiting for response from contributor
Projects
None yet
Development

No branches or pull requests

3 participants