Linter: revive, Rule: redundant-import-alias - warns on redundant import aliases. Should we enable it?

[zak-pawel]

Description

This issue starts a discussion about enabling:

• linter: revive - Fast, configurable, extensible, flexible, and beautiful linter for Go. Drop-in replacement of golint. Revive provides a framework for development of custom rules, and lets you define a strict preset for enhancing your development & code review processes.
• rule: redundant-import-alias - This rule warns on redundant import aliases. This happens when the alias used on the import statement matches the imported package name.

Example configuration:

      - name: redundant-import-alias

Expected output

Decision about enabling or not enabling this rule.

Findings

For this rule (with above configuration), the following findings were found in the current codebase:

plugins/inputs/kube_inventory/daemonset.go:6:2                                  revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/kube_inventory/daemonset_test.go:9:2                             revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/kube_inventory/deployment.go:6:2                                 revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/kube_inventory/deployment_test.go:9:2                            revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/kube_inventory/endpoint_test.go:7:2                              revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/kube_inventory/statefulset.go:6:2                                revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/kube_inventory/statefulset_test.go:9:2                           revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/kubernetes/kubernetes.go:15:2                                    revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/mysql/mysql.go:23:2                                              revive  redundant-import-alias: Import alias "v1" is redundant
plugins/inputs/mysql/mysql.go:24:2                                              revive  redundant-import-alias: Import alias "v2" is redundant
plugins/outputs/application_insights/mocks/diagnostics_message_listener.go:3:8  revive  redundant-import-alias: Import alias "mock" is redundant
plugins/outputs/http/http.go:18:2                                               revive  redundant-import-alias: Import alias "v4" is redundant
plugins/outputs/prometheus_client/prometheus_client.go:27:2                     revive  redundant-import-alias: Import alias "v1" is redundant
plugins/outputs/prometheus_client/prometheus_client.go:28:2                     revive  redundant-import-alias: Import alias "v2" is redundant