Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Arithmetic operators like abs and mod are still not implemented in Python. #1628

Closed
1 task done
writinwaters opened this issue Aug 9, 2024 · 3 comments
Closed
1 task done

[Feature Request]: Arithmetic operators like abs and mod are still not implemented in Python. #1628

writinwaters opened this issue Aug 9, 2024 · 3 comments
Assignees
@JinHai-CN
Labels
feature request New feature or request

Comments

@writinwaters
Copy link
Contributor

writinwaters commented Aug 9, 2024 •
edited by JinHai-CN
Loading

Is there an existing issue for the same feature request?

  • I have checked the existing issues.

Describe the feature you'd like

Implement support for abs and mod in Python method output().
@writinwaters writinwaters added the feature request New feature or request label Aug 9, 2024
@JinHai-CN
Copy link
Contributor

Fixed by #1630

@JinHai-CN JinHai-CN mentioned this issue Aug 9, 2024
Merged
1 task
JinHai-CN added a commit that referenced this issue Aug 9, 2024
@JinHai-CN
Support function expression when filter data. (#1630)
007ab03 
### What problem does this PR solve?

Support:
`
table_instance.output(["num", "name", "abs(score)",
"score"]).filter("(abs(score) <= 90.0)").to_pl()
`

Issues: #1625 #1628

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)

---------

Signed-off-by: Jin Hai <[email protected]>
@writinwaters
Copy link
Contributor Author

Please note abs() is implemented in output(), but not yet implemented in filter().

@writinwaters writinwaters removed their assignment Aug 12, 2024
@yangzq50
Copy link
Contributor

Please note abs() is implemented in output(), but not yet implemented in filter().

Is this still a problem now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JinHai-CN JinHai-CN

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JinHai-CN @yangzq50 @writinwaters