Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes not detected/included when building .modl from perspective-component using the newer open-sourced plugin #96

Open
BjAlvestad opened this issue Dec 2, 2022 · 2 comments

Comments

@BjAlvestad
Copy link

Using ./gradle zipModule (or ./gradle build w/dummy certificate) to build a module file, it will not detect and include changes done in common, designer or gateway. Only if a change has been done in web will a new modl file actually get created.

It will correctly generate a modl file upon first call after cloning the repo. But for subsequent calls, it does not detect that java/json files has changed.

Issue was not present in older version using ./gradle buildModule

Could it be linked to the following issue?
inductiveautomation/ignition-module-tools#28

On a related note:
Previously build number was added as byyyymmddHH, but for all builds with the newest version we only get b0. Is this as expected?


Steps to reproduce:

  • Check out latest version of perspective-component
  • Open git bash in repo on a PC running windows 10
  • Run ./gradlew build or ./gradlew zipModule --> A .modl file gets created
  • Make a change to common/src/main/resources/*.json
  • Run ./gradlew build or ./gradlew zipModule --> No new .modl file will be created (unless old file was deleted manually first).

You can force it to create a modl file that actually contains the changes in /common/src/main/resources by deleting /common/build before running ./gradlew build. This results in a new .modl file creation, that actually includes the changes made to the json file.
PS: designer does not notify that it requires restart - you must do that manually before changes can be seen.

@PerryAJ
Copy link
Member

PerryAJ commented Dec 2, 2022

Thanks for submitting this, we'll get it looked at. I wouldn't be surprised if the issue you noted was related.

Previously build number was added as byyyymmddHH, but for all builds with the newest version we only get b0. Is this as expected?

Can you be more specific where this is happening?

@BjAlvestad
Copy link
Author

BjAlvestad commented Dec 2, 2022

Thanks for submitting this, we'll get it looked at. I wouldn't be surprised if the issue you noted was related.

Previously build number was added as byyyymmddHH, but for all builds with the newest version we only get b0. Is this as expected?

Can you be more specific where this is happening?

Sorry, I was a bit unclear there.
What I meant to say, is that when we load our modl file in Ignition we can see the x.y.z that we set our selves. But in addition we can also see a build number in brackets.

Previously this build number was set automatically as e.g. (b2022120315) for a file built at 2022-12-03 15:nn.

With the new version the build number is always at (b0).
Now I am not sure if that is actually a symptom of some issue (e.g. that it was meant to increment automatically), or if there is somewhere that we are meant to connect to ourselves, to make it increment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants