Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle error on fresh generated module skeleton #49

Closed
thirdgen88 opened this issue Jul 24, 2024 · 3 comments
Closed

Gradle error on fresh generated module skeleton #49

thirdgen88 opened this issue Jul 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@thirdgen88
Copy link
Member

When using generator-cli, a freshly created project produces the following Gradle error when attempting to build:

* What went wrong:
Script compilation error:

  Line 90:     moduleDependencySpecs { }
               ^ Unresolved reference: moduleDependencySpecs

This appears to be due to the templating in generator still emitting version 0.1.1 for the Ignition Module Plugin (io.ia.sdk.modl) instead of the latest 0.3.0 (where moduleDependencySpecs was introduced). In a quick search through the code, it looks like we might need to update a few areas where the previous version number was used; hopefully we can DRY that up in the process.

@thirdgen88 thirdgen88 added this to the 0.3.1 milestone Jul 24, 2024
@thirdgen88 thirdgen88 added the bug Something isn't working label Jul 24, 2024
@brianeray brianeray self-assigned this Jul 24, 2024
@brianeray
Copy link
Collaborator

For internal tracking purposes: IGN-10597.

@brianeray
Copy link
Collaborator

Local testing with the #54 commit suggests that lining up all the version references from generator logic to gradle-module-plugin's version does the trick.

.\gradlew.bat --% build

# ...

> Task :signModule SKIPPED
useUnsignedModule specified in Module Settings. Module Signing will be skipped

BUILD SUCCESSFUL in 932ms
8 actionable tasks: 2 executed, 6 up-to-date

There are several other patches to fit into this release but once 0.4.0 is ready, I'll close out this issue.

brianeray added a commit to brianeray/ignition-module-tools that referenced this issue Aug 27, 2024
This should also close issue inductiveautomation#49.
brianeray added a commit to brianeray/ignition-module-tools that referenced this issue Aug 28, 2024
This should also close issue inductiveautomation#49.
brianeray added a commit that referenced this issue Aug 28, 2024
This should also close issue #49.
@brianeray
Copy link
Collaborator

#59 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants