Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generation has quadratic complexity in the DAG size of each expression generated #162

Open
inducer opened this issue Oct 12, 2021 · 0 comments
Open

Code generation has quadratic complexity in the DAG size of each expression generated #162

inducer opened this issue Oct 12, 2021 · 0 comments
Assignees
@matthiasdiener

Comments

@inducer
Copy link
Owner

inducer commented Oct 12, 2021 •
edited
Loading

The source of the problem is this substitution:

pytato/pytato/target/loopy/codegen.py

Line 89 in 08ba927

return SubstitutionMapper(make_subst_func(variable_assigments))(expression)

which causes a re-traversal of each expression node already generated.

A not-yet functional draft approach to this is in 61690f4, using inducer/pymbolic#62.

cc @thomasgibson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiasdiener matthiasdiener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inducer @matthiasdiener