Preserve expression structure of in Expression.(__add__|__mul__|...)
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
changed the title
Expression.(__add__|__mul__|...)
inducer
reviewed
May 3, 2022
Comment on lines
-438
to
-440
| if all(child is orig_child | ||
| for child, orig_child in zip(children, expr.children)): | ||
| return expr |
There was a problem hiding this comment.
How come these got removed? IIRC @isuruf found them essential for making no-op traversals cheap in loopy.
There was a problem hiding this comment.
Yep, I'll revert them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was suggested in inducer/pytato#217 that we should preserve the structure of the expressions. This PR implements the points discussed over there.
Draft because: