From 51853022e2d729f3b701484ada23f8454758121b Mon Sep 17 00:00:00 2001 From: Alexandru Fikl Date: Tue, 6 Aug 2024 09:17:40 +0300 Subject: [PATCH] mesh: remove typing ignore for override --- meshmode/mesh/__init__.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/meshmode/mesh/__init__.py b/meshmode/mesh/__init__.py index 8b2871e0..7e04fb0c 100644 --- a/meshmode/mesh/__init__.py +++ b/meshmode/mesh/__init__.py @@ -315,7 +315,7 @@ def vertex_unit_coordinates(self) -> np.ndarray: @classmethod @abstractmethod - def make_group(cls, **kwargs: Any) -> MeshElementGroup: + def make_group(cls, *args: Any, **kwargs: Any) -> MeshElementGroup: """Instantiate a new group of class *cls*. Unlike the constructor, this factory function performs additional @@ -361,13 +361,12 @@ def vertex_unit_coordinates(self) -> np.ndarray: return mp.unit_vertices_for_shape(self._modepy_shape).T @classmethod - # Type ignore because I do not know how to annotate this factory - # function usage. Possible reference: - # https://github.com/python/typing/discussions/1191#discussioncomment-2796173 - def make_group(cls, order: int, # type: ignore[override] + def make_group(cls, + order: int, vertex_indices: np.ndarray | None, nodes: np.ndarray, - *, unit_nodes: np.ndarray | None = None, + *, + unit_nodes: np.ndarray | None = None, dim: int | None = None) -> _ModepyElementGroup: if unit_nodes is None: