Switch immutables.Map and pyrsistent.PMap to constantdict #832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently a proof-of-concept.
Edit: I removed the previous performance results, they were likely caused by some kind of caching of kernels.
TODOs:
add(or change the singlemutate
support to constantdict (and perhaps immutabledict)mutate
call)from constantdict import constantdict as Map
=>from constantdict import constantdict
Perhaps removesorted
calls (likely in a separate PR)pytools
releasePlease squash