Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements loop distribution transformation #629

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kaushikcfd
Copy link
Collaborator

@kaushikcfd kaushikcfd commented Jun 14, 2022

TODO:

  • Do index analysis to verify the validity of the iname-duplication passes.
  • Add complicated regressions.

Draft because:

@kaushikcfd kaushikcfd force-pushed the distribute_loops branch 8 times, most recently from 1530258 to 0bbac87 Compare June 19, 2022 22:26
@kaushikcfd
Copy link
Collaborator Author

This is on hold currently as @inducer and I agreed in a personal chat that:

  1. The soundness checking is hokey and must wait for proper dependencies in loopy.
  2. The greedy approach of selecting the duplication groups doesn't achieve minima and even in practical cases does not get a reasonable solution.

@inducer
Copy link
Owner

inducer commented Jun 20, 2022

The soundness checking is hokey and must wait for proper dependencies in loopy.

To the extent that this is @kaushikcfd channeling what I said, I feel I should reword this. 🙂 This PR introduces special-purpose soundness checking for the case of loop distribution. While that's clearly useful and important, I think that this could be (more precisely, and at the same in a non-special-purpose manner) handled by generic dependency checking along the lines of #479. That's something I'd like to make some progress toward this summer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants