Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulator name after lp.realize_reduction is intractable #713

Open
kaushikcfd opened this issue Dec 18, 2022 · 1 comment
Open

Accumulator name after lp.realize_reduction is intractable #713

kaushikcfd opened this issue Dec 18, 2022 · 1 comment
Assignees

Comments

@kaushikcfd
Copy link
Collaborator

Maybe the newly introduced accumulator variables should be tagged with some specifications or the naming must be standardized. In feinsum, I have to rely on internals of realize_redudction (cf https://github.com/kaushikcfd/feinsum/blob/87e3a43dff6ebbc3709a3afc9df174ab2e12c8fa/src/feinsum/tuning/impls/ifj_fe_fej_to_ei.py#L447-L448) making the transformation fragile for long-term storage.

@inducer
Copy link
Owner

inducer commented Dec 27, 2022

I think a tag on the variable would be the cleanest solution. PRs welcome.

@kaushikcfd kaushikcfd self-assigned this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants