Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FusionContractorArrayContext fallbacks optional (disabled by default) #331

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Feb 27, 2024

Updates MPIPytatoArrayContextBase.__init__ to pass along the arguments added to FusionContractorArrayContext to override the new default fallback behavior (raising an exception).

@majosm
Copy link
Collaborator Author

majosm commented Feb 27, 2024

Hrm, I don't think this is going to work as-is. Looks like MPIPytatoArrayContextBase needs to be compatible with both FusionContractorArrayContext and PytatoPyOpenCLArrayContext, which now have different __init__ arguments.

@inducer, @matthiasdiener Any thoughts on how to refactor this to make it work? Multiple inheritance in Python is not my strong suit...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant