Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper symbolic tag negotiation for eager #223

Open
inducer opened this issue Mar 2, 2022 · 2 comments
Open

Implement proper symbolic tag negotiation for eager #223

inducer opened this issue Mar 2, 2022 · 2 comments

Comments

@MTCam
Copy link
Collaborator

MTCam commented Mar 3, 2022

Just a quick related note... the code here:

tag_ub = actx.mpi_communicator.Get_attr(MPI.TAG_UB)

fails for array contexts that do not have the mpi_communicator attribute, but do pass a comm_tag. MIRGE-Com does this when it calls interior_trace_pairs, for example here:

https://github.com/illinois-ceesd/mirgecom/blob/452186f0365a5969e55693e07f87caeb712981d6/mirgecom/euler.py#L153

I'll spare you the generated error, but I've just a pushed a drive-by to fix the problem. #226

@inducer
Copy link
Owner Author

inducer commented Mar 4, 2022

I've started putting some work towards this (#233) before realizing that this is all thoroughly pointless: Eager grudge can only have communication for one tag pending at the same time, otherwise it would deadlock. Therefore, all ranks must hit eager communication in the same order, and so we can do with these tags whatever we want; it won't matter until we allow multiple communications to be pending at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants