From d0bd17e6bafce8bc98888bb9309bf4089ae295a0 Mon Sep 17 00:00:00 2001 From: Addison Alvey-Blanco Date: Tue, 1 Aug 2023 13:15:07 -0500 Subject: [PATCH] Add arg names to geometric factor application, refine some comments --- grudge/op.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/grudge/op.py b/grudge/op.py index c6e6ce36..c2f73d0e 100644 --- a/grudge/op.py +++ b/grudge/op.py @@ -167,6 +167,8 @@ # {{{ Temporary tools for tensor product operators +# NOTE: Will possibly be removed in a future version of tensor product operator +# development since (I think) it is not entirely necessary from pytools.tag import Tag class OutputIsTensorProductDOFArrayOrdered(Tag): pass @@ -251,7 +253,8 @@ def compute_tensor_product_grad(actx, grp, diff_mat, vec, ijm): vec = reshape_array_for_tensor_product_space(grp.space, vec) # apply differentiation matrix to vec - # check len(vec.shape) since shape is expected to be (nelements, ndofs) + # check len(vec.shape) since shape is expected to be + # (nelements, nnodes1d, nnodes1d) if len(vec.shape) == 3: specs = ["il,elj->eij", "jl,eil->eij"] @@ -294,7 +297,8 @@ def compute_tensor_product_grad(actx, grp, diff_mat, vec, ijm): "rei,ei->ei", ijm[i], grad[i], - tagged=(FirstAxisIsElementsTag(),)) + tagged=(FirstAxisIsElementsTag(),)), + arg_names=("inv_jac_t", "vec") for i in range(grad.shape[0]) ])