Fix new mypy 1.12 errors #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Oct 14, 2024
| @@ -83,14 +83,15 @@ def is_array_field(f: Field) -> bool: | |||
| f"Field '{f.name}' union contains non-array container " | |||
| "arguments. All arguments must be array containers.") | |||
|
|
|||
| if isinstance(f.type, str): | |||
There was a problem hiding this comment.
f.type is now correctly a Union[type[Any], str], which disagreed with is_array_type below. This just moves the check out of if __debug__ to let mypy know we handle that case.
There was a problem hiding this comment.
Sounds good. In the short-ish term, we'll probably need to handle this case better, too. Maybe just tossing it to parse might be enough? (though some of the identifiers may not resolve?) At any rate, a discussion for a different day.
alexfikl
force-pushed
the
fix-mypy-1-12
branch
from
c263375
to
10c4221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.