Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid setting force_device_scalars=False #278

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Forbid setting force_device_scalars=False #278

merged 2 commits into from
Sep 4, 2024

Conversation

majosm
Copy link
Collaborator

@majosm majosm commented Aug 13, 2024 •
edited by inducer
Loading

@majosm majosm force-pushed the always-force-device-scalars branch 3 times, most recently from c148497 to b4b0f1e Compare August 13, 2024 21:06
@majosm majosm mentioned this pull request Aug 13, 2024
Merged
8 tasks
@majosm
Copy link
Collaborator Author

majosm commented Aug 13, 2024

Looks like the default value of force_device_scalars will need to be changed in the meshmode/grudge array context constructors before this can be merged. I'll wait until this gets a tentative go-ahead before doing that.

alexfikl
alexfikl reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@alexfikl alexfikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been deprecated for a long time now, so I'm definitely in favor! 🎉

arraycontext/impl/pyopencl/__init__.py Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Aug 14, 2024

Very much in favor as well!

@majosm majosm mentioned this pull request Aug 16, 2024
Merged
@majosm majosm force-pushed the always-force-device-scalars branch from c2ab44f to b4b0f1e Compare August 16, 2024 02:16
@majosm majosm mentioned this pull request Aug 16, 2024
Merged
@majosm majosm marked this pull request as ready for review August 16, 2024 15:53
@majosm majosm requested a review from inducer August 16, 2024 15:54
@majosm
Copy link
Collaborator Author

majosm commented Aug 16, 2024

Ruff errors appear to be unrelated, so I think this is ready for a look. inducer/meshmode#429 and inducer/grudge#358 should probably get merged before this.

@inducer inducer enabled auto-merge (squash) September 4, 2024 20:50
@inducer inducer merged commit 46a5cfe into inducer:main Sep 4, 2024
12 checks passed
@majosm majosm mentioned this pull request Sep 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfikl alexfikl alexfikl left review comments

@inducer inducer Awaiting requested review from inducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majosm @inducer @alexfikl