Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to new TranslationUnit.executor #240

Closed
wants to merge 1 commit into from

Conversation

alexfikl
Copy link
Collaborator

This caches the executor in _loopy_transform_cache. Is that ok?

@inducer
Copy link
Owner

inducer commented Jul 26, 2023

Thanks!

I was working on also using the executor stuff in the lazy codepath, which required a bit of a detour. Otherwise, I already have analogous changes lined up (with the addition of also using the executor business on freeze).

Caching in _loopy_transform_cache is just fine: That's specific to an array context, which is itself specific to a CL context, so there's no risk of holding an uninvited reference to a CL context.

Still, I'll close this in favor of my version of this. Thanks again for making this, and sorry about the duplicate work.

@inducer inducer closed this Jul 26, 2023
@inducer
Copy link
Owner

inducer commented Jul 27, 2023

Superseded by #241.

@alexfikl alexfikl deleted the port-tunit-executor branch July 30, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants