disable array bounds check when optimized #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
force-pushed
the
array-check-no-opt
branch
from
6b58ceb
to
afe2d3c
Compare
inducer
reviewed
Jul 25, 2023
| @@ -41,7 +43,9 @@ | |||
|
|
|||
| _DEFAULT_LOOPY_OPTIONS = lp.Options( | |||
| no_numpy=True, | |||
| return_dict=True) | |||
| return_dict=True, | |||
| enforce_array_accesses_within_bounds="no_check" if sys.flags.optimize | |||
There was a problem hiding this comment.
I'm a bit hesitant about this, because I feel it encourages everyone to run with -O all the time, negating the benefit of possible runtime checks.
I think a possibly better approach might be to just turn off bounds checking for kernels generated by pytato wholesale, as long as no hand-written loopy kernels appear in the DAG.
|
Closing in favor of inducer/pytato#449. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: