Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container serialize/deserialize: Do we need the keys? #92

Open
inducer opened this issue Sep 26, 2021 · 2 comments
Open

Container serialize/deserialize: Do we need the keys? #92

inducer opened this issue Sep 26, 2021 · 2 comments

Comments

@inducer
Copy link
Owner

inducer commented Sep 26, 2021

When reviewing #91, it occurred to me that, at least for all our current use cases, we're completely fine with "positional" deserialization, and the keys are kind of a waste. Should we get rid of them?

One counterpoint is that the keys do provide metadata that pytato uses to generate better names.

cc @alexfikl @thomasgibson @kaushikcfd Thoughts?

@inducer
Copy link
Owner Author

inducer commented Sep 26, 2021

(But the naming concern feels a bit orthogonal: That metadata could conceivably be added by/obtained from someplace else.)

@alexfikl
Copy link
Collaborator

Another counterpoint is that they're quite useful to check that deserialize_container didn't get garbage data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants