Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config validation #18

Open
lawrencejones opened this issue May 3, 2023 · 2 comments
Open

Improve config validation #18

lawrencejones opened this issue May 3, 2023 · 2 comments

Comments

@lawrencejones
Copy link
Member

The errors are a bit messy. If you fail to parse the file, we print the default template output, which is confusing.

If you use keys that aren't recognised, we'll accept them: this is particularly confusing.

@lawrencejones
Copy link
Member Author

Detection of duplicate type names would be great too.

@lawrencejones
Copy link
Member Author

#65 will fix the unrecognised key problem, but several things still left to improve:

  • General output: it's hard to see the error and the pretty-printing of the config isn't helping anyone.
  • Duplicate type names.
  • Other logical config errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant