Merge pull request #329 from mvpossum/master

Fix find_by when offset is greater than available objects
inaka · Dec 2, 2017 · 30eb43a · 30eb43a
2 parents 2bdbc5f + adb65f6
commit 30eb43a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/adapter_test_helpers/sumo_basic_test_helper.erl b/src/adapter_test_helpers/sumo_basic_test_helper.erl
@@ -108,6 +108,8 @@ find_by(Config) ->
   %% Check pagination
   Results1 = sumo:find_by(Name, [], 3, 1),
   [_, _, _] = Results1,
+  [_, _, _, _, _, _, _] = sumo:find_by(Name, [], 1000, 1),
+  [] = sumo:find_by(Name, [], 1, 1000),
 
   %% This test is #177 github issue related
   [_, _, _, _, _, _, _, _] = sumo:find_by(Name, []),

diff --git a/src/adapters/sumo_store_mnesia.erl b/src/adapters/sumo_store_mnesia.erl
@@ -188,8 +188,10 @@ find_by(DocName, Conditions, [], Limit, Offset, State) ->
   end,
   TransactionL = fun() ->
     case mnesia:select(DocName, MatchSpec, Offset + Limit, read) of
-      {ManyItems, _Cont} ->
+      {ManyItems, _Cont} when length(ManyItems) >= Offset ->
         lists:sublist(ManyItems, Offset + 1, Limit);
+      {_ManyItems, _Cont} ->
+        [];
       '$end_of_table' ->
         []
     end