Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-CHANGELOG] upgrade biome and migrate for breaking changes #584

Merged
merged 4 commits into from
Jul 21, 2023
Merged

[NO-CHANGELOG] upgrade biome and migrate for breaking changes #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36d83df
upgrade biome and migrate for breaking changes
glomotion Jul 20, 2023
5ed7776
migrate away from the use of MountedBottomSheetOverlayAndProvider (it…
glomotion Jul 20, 2023
d1ead5e
Merge branch 'main' into feature/NOJIRA-migrate-biome
glomotion Jul 21, 2023
f990954
Add back in spacing for error view sentence formatting
imx-mikhala Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,018 changes: 739 additions & 279 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/checkout/sdk-sample-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
]
},
"dependencies": {
"@biom3/react": "^0.6.4-beta",
"@biom3/react": "^0.8.0-beta",
"@imtbl/checkout-sdk": "0.0.0",
"@imtbl/config": "0.0.0",
"ethers": "^5.7.2",
Expand Down
8 changes: 6 additions & 2 deletions packages/checkout/sdk-sample-app/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
import { MenuItem } from '@biom3/react';
import { MenuItem } from "@biom3/react";

export default function App() {
return (
<>
<MenuItem href="/connect" emphasized size="medium">
<MenuItem
renderContainer={(props) => <a {...props} href="/connect" />}
emphasized
size="medium"
>
<MenuItem.IntentIcon icon="ArrowForward" />
<MenuItem.Label>Connect</MenuItem.Label>
<MenuItem.Caption>
Expand Down
5 changes: 4 additions & 1 deletion packages/checkout/widgets-lib/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@
],
"class-methods-use-this": ["off"],
"react/require-default-props": ["off"],
"react/react-in-jsx-scope": ["off"]
"react/react-in-jsx-scope": ["off"],
"jsx-a11y/anchor-is-valid": "off",
"jsx-a11y/anchor-has-content": "off",
"react/jsx-props-no-spreading": "off",
}
}
2 changes: 1 addition & 1 deletion packages/checkout/widgets-lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"dependencies": {
"@biom3/design-tokens": "0.2.0-beta",
"@biom3/react": "^0.6.4-beta",
"@biom3/react": "^0.8.0-beta",
"@ethersproject/providers": "^5.7.2",
"@imtbl/bridge-sdk": "0.0.0",
"@imtbl/checkout-sdk": "0.0.0",
Expand Down
6 changes: 3 additions & 3 deletions packages/checkout/widgets-lib/src/components/SimpleLayout/SimpleLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Box, MountedBottomSheetOverlayAndProvider } from '@biom3/react';
import { Box, MountedOverlaysAndProvider } from '@biom3/react';
import {
simpleLayoutStyle,
headerStyle,
Expand Down Expand Up @@ -29,7 +29,7 @@ export function SimpleLayout({
footerBackgroundColor,
}: SimpleLayoutProps) {
return (
<MountedBottomSheetOverlayAndProvider containerId="layout-container">
<MountedOverlaysAndProvider bottomSheetContainerId="layout-container">
<Box sx={responsiveStyles} id="layout-container">
<Box testId={testId} sx={simpleLayoutStyle}>
{header && (
Expand All @@ -56,6 +56,6 @@ export function SimpleLayout({
)}
</Box>
</Box>
</MountedBottomSheetOverlayAndProvider>
</MountedOverlaysAndProvider>
);
}
7 changes: 6 additions & 1 deletion packages/checkout/widgets-lib/src/views/error/ErrorView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ export function ErrorView({
<SimpleTextBody heading={errorText.heading}>
{errorText.body[0]}
{' '}
<Link size="small" href="https://support.immutable.com/en/">
<Link
size="small"
renderContainer={(props) => (
<a {...props} href="https://support.immutable.com/en/" />
)}
>
{errorText.body[1]}
</Link>
{' '}
Expand Down
2 changes: 1 addition & 1 deletion packages/checkout/widgets-sample-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"dependencies": {
"@biom3/design-tokens": "0.2.0-beta",
"@biom3/react": "^0.6.4-beta",
"@biom3/react": "^0.8.0-beta",
"@imtbl/checkout-sdk": "0.0.0",
"@imtbl/checkout-widgets": "0.0.0",
"@imtbl/config": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/passport/sdk-sample-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"dependencies": {
"@biom3/design-tokens": "0.2.0-beta",
"@biom3/react": "^0.6.4-beta",
"@biom3/react": "^0.8.0-beta",
"@imtbl/config": "0.0.0",
"@imtbl/core-sdk": "^1.1.1-alpha.1",
"@imtbl/immutablex-client": "0.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/provider/src/sample-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
]
},
"dependencies": {
"@biom3/react": "^0.6.4-beta",
"@biom3/react": "^0.8.0-beta",
"@imtbl/core-sdk": "^1.1.1-alpha.1",
"@imtbl/sdk": "0.0.0",
"@testing-library/jest-dom": "^5.16.5",
Expand Down
Loading