Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-CHANGELOG] upgrade biome and migrate for breaking changes #584

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

glomotion
Copy link
Contributor

@glomotion glomotion commented Jul 20, 2023

Summary

Updating BIOME to the latest version + migrating breaking changes

Why the changes

To keep biome up to date.

Things worth calling out

Sadly, we needed to disable some eslint rules - due to them not being smart enough to handle renderProp components.

@glomotion glomotion requested review from a team as code owners July 20, 2023 05:46
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Skipping changelog updated check. Detected NO-CHANGELOG in PR title.

@glomotion glomotion changed the title upgrade biome and migrate for breaking changes [NO-CHANGELOG] upgrade biome and migrate for breaking changes Jul 20, 2023
@glomotion glomotion enabled auto-merge (squash) July 21, 2023 00:46
@glomotion glomotion merged commit 978203c into main Jul 21, 2023
4 checks passed
@glomotion glomotion deleted the feature/NOJIRA-migrate-biome branch July 21, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants