Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TP-1353][NO-CHANGELOG] secondary fees config #579

Merged
merged 5 commits into from
Jul 21, 2023
Merged

[TP-1353][NO-CHANGELOG] secondary fees config #579

merged 5 commits into from
Jul 21, 2023

Conversation

Benjimmutable
Copy link
Contributor

@Benjimmutable Benjimmutable commented Jul 20, 2023 •
edited
Loading

Summary

We want to configure the Exchange class to be able to read the secondary fee details.

Why the changes

Things worth calling out

@Benjimmutable Benjimmutable self-assigned this Jul 20, 2023
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited
Loading

Skipping changelog updated check. Detected NO-CHANGELOG in PR title.

@Benjimmutable Benjimmutable changed the title [TP-1354] secondary fees config [NO-CHANGELOG] secondary fees config Jul 20, 2023
@Benjimmutable Benjimmutable marked this pull request as ready for review July 20, 2023 02:40
@Benjimmutable Benjimmutable requested a review from a team as a code owner July 20, 2023 02:40
keithbro-imx
keithbro-imx reviewed Jul 20, 2023
View reviewed changes
packages/internal/dex/sdk/src/config/config.test.ts Outdated Show resolved Hide resolved
packages/internal/dex/sdk/src/exchange.ts Outdated Show resolved Hide resolved
packages/internal/dex/sdk/src/config/index.ts Outdated Show resolved Hide resolved
packages/internal/dex/sdk/src/types/index.ts Outdated Show resolved Hide resolved
packages/internal/dex/sdk/src/types/index.ts Outdated Show resolved Hide resolved
pano-skylakis
pano-skylakis reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@pano-skylakis pano-skylakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 🎉 just a couple of comments

packages/internal/dex/sdk/src/types/index.ts Outdated Show resolved Hide resolved
packages/internal/dex/sdk/src/config/config.test.ts Outdated Show resolved Hide resolved
packages/internal/dex/sdk/src/config/config.test.ts Outdated Show resolved Hide resolved
packages/internal/dex/sdk/src/config/config.test.ts Outdated Show resolved Hide resolved
@Benjimmutable Benjimmutable enabled auto-merge (squash) July 21, 2023 03:55
@Benjimmutable Benjimmutable merged commit 9a21498 into main Jul 21, 2023
4 checks passed
@Benjimmutable Benjimmutable deleted the tp-1354-secondary-fee-config branch July 21, 2023 04:09
@pano-skylakis pano-skylakis changed the title [NO-CHANGELOG] secondary fees config [TP-1353][NO-CHANGELOG] secondary fees config Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pano-skylakis pano-skylakis pano-skylakis approved these changes

@keithbro-imx keithbro-imx keithbro-imx approved these changes

Assignees

@Benjimmutable Benjimmutable

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Benjimmutable @pano-skylakis @keithbro-imx