Fix bignumber convert to number overflow issue [NO-CHANGELOG] (#616)

immutable · Jul 31, 2023 · 8f5bdf8 · 8f5bdf8
1 parent 563079a
commit 8f5bdf8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/packages/internal/guardian/src/client/models/zk-evm-transaction-data.ts b/packages/internal/guardian/src/client/models/zk-evm-transaction-data.ts
@@ -37,9 +37,9 @@ export interface ZkEvmTransactionData {
     'metaTransactions': Array<MetaTransaction>;
     /**
      * The nonce value
-     * @type {number}
+     * @type {string}
      * @memberof ZkEvmTransactionData
      */
-    'nonce': number;
+    'nonce': string;
 }
 
diff --git a/packages/passport/sdk/src/guardian/guardian.test.ts b/packages/passport/sdk/src/guardian/guardian.test.ts
@@ -103,7 +103,7 @@ describe('guardian', () => {
       await expect(
         guardianClient.validateEVMTransaction({
           chainId: 'epi123',
-          nonce: 5,
+          nonce: '5',
           user: mockUserZkEvm,
           metaTransactions: [
             {

diff --git a/packages/passport/sdk/src/guardian/guardian.ts b/packages/passport/sdk/src/guardian/guardian.ts
@@ -20,21 +20,21 @@ export type GuardianValidateParams = {
 
 type GuardianEVMValidationParams = {
   chainId: string,
-  nonce: number,
+  nonce: string,
   user: UserZkEvm,
   metaTransactions: MetaTransaction[],
 };
 
-export const convertBigNumberishToNumber = (value: ethers.BigNumberish): number => BigNumber.from(value).toNumber();
+export const convertBigNumberishToString = (value: ethers.BigNumberish): string => BigNumber.from(value).toString();
 
 const transformGuardianTransactions = (txs: MetaTransaction[]): guardian.MetaTransaction[] => {
   try {
     return txs.map((t) => ({
       delegateCall: t.delegateCall === true,
       revertOnError: t.revertOnError === true,
-      gasLimit: t.gasLimit ? convertBigNumberishToNumber(t.gasLimit).toString() : '0',
+      gasLimit: t.gasLimit ? convertBigNumberishToString(t.gasLimit) : '0',
       target: t.to ?? ethers.constants.AddressZero,
-      value: t.value ? convertBigNumberishToNumber(t.value).toString() : '0',
+      value: t.value ? convertBigNumberishToString(t.value) : '0',
       data: t.data ? t.data.toString() : '0x00',
     }));
   } catch (error) {

diff --git a/packages/passport/sdk/src/zkEvm/sendTransaction.test.ts b/packages/passport/sdk/src/zkEvm/sendTransaction.test.ts
@@ -36,7 +36,7 @@ describe('sendTransaction', () => {
     loading: jest.fn(),
   };
 
-  const nonce = 5;
+  const nonce = '5';
   const config: Partial<PassportConfiguration> = {
     zkEvmChainId: 'eip155:13392',
   };

diff --git a/packages/passport/sdk/src/zkEvm/sendTransaction.ts b/packages/passport/sdk/src/zkEvm/sendTransaction.ts
@@ -8,7 +8,7 @@ import { retryWithDelay } from '../network/retry';
 import { PassportConfiguration } from '../config';
 import { RelayerClient } from './relayerClient';
 import { UserZkEvm } from '../types';
-import GuardianClient, { convertBigNumberishToNumber } from '../guardian/guardian';
+import GuardianClient, { convertBigNumberishToString } from '../guardian/guardian';
 
 const MAX_TRANSACTION_HASH_RETRIEVAL_RETRIES = 30;
 const TRANSACTION_HASH_RETRIEVAL_WAIT = 1000;
@@ -87,7 +87,7 @@ export const sendTransaction = async ({
 
   await guardianClient.validateEVMTransaction({
     chainId: config.zkEvmChainId,
-    nonce: convertBigNumberishToNumber(nonce),
+    nonce: convertBigNumberishToString(nonce),
     user,
     metaTransactions: [metaTransaction, feeMetaTransaction],
   });