Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Someone decided that Zero before Minizip-ng Version build definition is a good idea. Now we have 8 in octal number and error in compilation. #24

Open
ssh4net opened this issue Aug 9, 2023 · 2 comments
Open

Someone decided that Zero before Minizip-ng Version build definition is a good idea. Now we have 8 in octal number and error in compilation. #24

ssh4net opened this issue Aug 9, 2023 · 2 comments

Comments

@ssh4net
Copy link

ssh4net commented Aug 9, 2023

I guess minizip-ng support was added before minizip-ng become 3.0.8 and compilation had no issues. Now when MZ is 3.0.8 compiling give an error.

/* MZ_VERSION */
#define MZ_VERSION                      ("3.0.8")
#define MZ_VERSION_BUILD                (030008)

#if MZ_VERSION_BUILD >= 040000

Zero on start treat octal number and 8 is not the digit that can be in such numbers
@KelSolaar
Copy link
Contributor

Hey Vlad,

Wrong repo, this is the one: https://github.com/AcademySoftwareFoundation/OpenColorIO

Cheers,

Thomas

@ssh4net
Copy link
Author

ssh4net commented Aug 10, 2023

Oh, sorry. Forgot to check 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KelSolaar @ssh4net