Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About culling down ACES versions. #13

Open
KelSolaar opened this issue Feb 17, 2018 · 9 comments
Open

About culling down ACES versions. #13

KelSolaar opened this issue Feb 17, 2018 · 9 comments

Comments

@KelSolaar
Copy link
Contributor

KelSolaar commented Feb 17, 2018

I would be keen on discussing about potentially removing the various ACES config versions in the ImageWorks repository and keep a single one that would maybe be a git-submodule hosted on an AMPAS dedicated repository.

@aforsythe, @scoopxyz, @lgritz (and anybody interested) any thoughts?

@scoopxyz
Copy link
Collaborator

I'm all for getting just the current ACES config in the master repo.

I would like to maintain the older versions by keeping a separate branch called "legacy". This should substantially decrease the repo size and make it quite clear to users what they should grab.

@KelSolaar
Copy link
Contributor Author

This should substantially decrease the repo size and make it quite clear to users what they should grab.

I could be wrong but without re-writing history I'm not sure the gains will be significant as you will still have the files in a blob within git tree.

@scoopxyz
Copy link
Collaborator

In my quick tests I'm seeing a download size reduction from 877.1 MB to 347 MB

@lgritz
Copy link
Member

lgritz commented Feb 17, 2018

Download of the zip will decrease, but the repo size (what you get if you git clone) will not. Even a local git repo has the full history of the project.

@lgritz
Copy link
Member

lgritz commented Feb 17, 2018

I'm all for removing the old ACES configs, and for that matter, even putting the extant ones in git LFS rather than in the main repo.

@dekekincaid
Copy link

dekekincaid commented Feb 17, 2018 via email

@KelSolaar
Copy link
Contributor Author

Download of the zip will decrease, but the repo size (what you get if you git clone) will not.

Yeah sorry, I was referring to repo size.

It would be good to have these properly setup.

Yes absolutely!

@scoopxyz
Copy link
Collaborator

scoopxyz commented Feb 18, 2018

Download of the zip will decrease, but the repo size (what you get if you git clone) will not

Yes, of course, but there are about 4-5 people doing development work on the repo, the majority use case is just downloading the files to use. I'll need to read a bit more about LFS to see how it integrates into things.

there still isn’t even a tagged released for aces

Yes, there was a sidebar conversation that prompted this ticket. Just needs to be done.

@KelSolaar
Copy link
Contributor Author

KelSolaar commented May 15, 2018

As highlighted in this comment, it should be possible to trim some fat by reducing indentation of the spi1d LUTs, some have 8 or 9 characters which is simply overkill.

Cheers,

Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants