ARCH-2011 - Updating for node20 versions & other updates #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danielle-casella-adams
commented
Mar 5, 2024
danielle-casella-adams
commented
- Update actions versions to use the node20 version
- Add an input for ms-teams-uri & deploy-notifications-channel for the finish reusable workflows. These are mainly defined as variables now but we're still treating them as secrets. Allow caller to provide it either way. +semver:minor
- Adding a step to each reusable workflow to print out the value of each input to make it easier to see what the workflow will be using
- Add update-deployment-board permissions to the deployment workflows with a TODO to remove once we are ready to switch to techhub deploys (this affected at least one team)
- Update actions versions to use the node20 version - Add an input for ms-teams-uri & deploy-notifications-channel for the finish reusable workflows. These are mainly defined as variables now but we're still treating them as secrets. Allow caller to provide it either way. +semver:minor - Adding a step to each reusable workflow to print out the value of each input to make it easier to see what the workflow will be using - Add update-deployment-board permissions to the deployment workflows with a TODO to remove once we are ready to switch to techhub deploys (this affected at least one team)
danielle-casella-adams
force-pushed
the
update-reusables
branch
11 times, most recently
from
9bc3b52
to
8664789
Compare
danielle-casella-adams
force-pushed
the
update-reusables
branch
from
8664789
to
fb97fc7
Compare
JosephDSchwartz
approved these changes
Mar 6, 2024
hpractv
reviewed
Mar 6, 2024
hpractv
approved these changes
Mar 6, 2024
Very sorry about that. I did a format on the reusable workflows when I was done editing and there were tons of changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.