Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-github-deployment #246

Merged
merged 4 commits into from
Feb 6, 2024
Merged

create-github-deployment #246

merged 4 commits into from
Feb 6, 2024

Conversation

hpractv
Copy link
Contributor

@hpractv hpractv commented Feb 2, 2024

Replaced update-deployment-board with create-github-deployment

@hpractv hpractv requested a review from a team as a code owner February 2, 2024 15:55
Comment on lines +80 to +84
entity:
description: 'The catalog-info.yml metadata.name value for mapping in Tech Hub.'
required: false
type: string
default: null

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is entity too ambiguous? Would backstage-entity clarify? I kind of have the same feelings about instance because it seems like a nebulous word and doesn't convey enough meaning. I think target is the terminology used in some of the other workflows. A change like that would probably require an update to your action.

@danielle-casella-adams
Copy link
Member

I forgot to add the comment to the review. In most of the workflows the last job is called update-deployment-board-and-send-teams-notification. Should that be updated? At a minimum I think we take the board part out.

@hpractv
Copy link
Contributor Author

hpractv commented Feb 5, 2024

I forgot to add the comment to the review. In most of the workflows the last job is called update-deployment-board-and-send-teams-notification. Should that be updated? At a minimum I think we take the board part out.

I'll change it to update-github-deployments-and-send-teams-notification.

- Removed the clean up deployment board workflow
@hpractv hpractv merged commit 86ac665 into main Feb 6, 2024
@hpractv hpractv deleted the github-deployments branch February 6, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants