-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-github-deployment #246
Conversation
workflow-templates/im-deploy-tf-auto-apply-main-to-dev-on-merge.yml
Outdated
Show resolved
Hide resolved
workflow-templates/im-deploy-tf-auto-apply-main-to-dev-on-merge.yml
Outdated
Show resolved
Hide resolved
entity: | ||
description: 'The catalog-info.yml metadata.name value for mapping in Tech Hub.' | ||
required: false | ||
type: string | ||
default: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is entity too ambiguous? Would backstage-entity clarify? I kind of have the same feelings about instance because it seems like a nebulous word and doesn't convey enough meaning. I think target is the terminology used in some of the other workflows. A change like that would probably require an update to your action.
I forgot to add the comment to the review. In most of the workflows the last job is called |
Co-authored-by: Danielle Adams <[email protected]>
I'll change it to |
- Removed the clean up deployment board workflow
Replaced update-deployment-board with create-github-deployment