Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update im-run-tf-import.yml #237

Closed
wants to merge 3 commits into from
Closed

Update im-run-tf-import.yml #237

wants to merge 3 commits into from

Conversation

michael-guthrie
Copy link

Moved Checkout step before bash step, to fix issue where WORKING_FOLDER does not exist because it has not yet been loaded by Checkout.

@michael-guthrie
Update im-run-tf-import.yml
3bab1a8 
Moved Checkout step before bash step, to fix issue where WORKING_FOLDER does not exist because it has not yet been loaded by Checkout.
@michael-guthrie michael-guthrie requested a review from a team as a code owner October 4, 2023 21:21
mike-schenk
mike-schenk reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mike-schenk mike-schenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this change could fix any problem. I don't see anything in the run step that could depend on the checkout.

Can you show an example of such a problem?

@michael-guthrie
Copy link
Author

I don't see how this change could fix any problem. I don't see anything in the run step that could depend on the checkout.

Can you show an example of such a problem?

https://github.com/im-funding/funding-communication-infrastructure/actions/runs/6411365055/job/17406646574#step:2:31

Essentially the working-directory: '${{ env.TF_WORKING_DIR }}' doesn't represent a folder that exists before the code itself is pulled down.

@michael-guthrie
Copy link
Author

These three objects look to have been deleted altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-schenk mike-schenk mike-schenk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-guthrie @mike-schenk