Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doublemach_physical_av: lazy fixes #758

Merged
merged 1 commit into from
Sep 20, 2022
Merged

doublemach_physical_av: lazy fixes #758

merged 1 commit into from
Sep 20, 2022

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Sep 20, 2022 •
edited
Loading

Partial fix for #754.
Also needs inducer/arraycontext#193.

Supersedes #756.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener mentioned this pull request Sep 20, 2022
Closed
8 tasks
MTCam
MTCam reviewed Sep 20, 2022
View reviewed changes
examples/doublemach_physical_av-mpi.py
# current_grad_cv = grad_cv_operator(
# dcoll, gas_model, boundaries, current_state, time=current_t,
# quadrature_tag=quadrature_tag)
current_grad_cv = grad_cv_operator_compiled(current_state, current_t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't call compiled functions down inside the RHS.

@matthiasdiener matthiasdiener marked this pull request as ready for review September 20, 2022 15:42
@MTCam MTCam merged commit 2e9ed07 into production Sep 20, 2022
@MTCam MTCam deleted the doublemacha-v-lazy branch September 20, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MTCam MTCam MTCam left review comments

@anderson2981 anderson2981 Awaiting requested review from anderson2981

@inducer inducer Awaiting requested review from inducer

@kaushikcfd kaushikcfd Awaiting requested review from kaushikcfd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasdiener @MTCam