Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pyvisfile non-editable #1046

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Make pyvisfile non-editable #1046

merged 3 commits into from
Jul 20, 2024

Conversation

matthiasdiener
Copy link
Member

@matthiasdiener matthiasdiener commented Jul 16, 2024

Works around #1044, inducer/pyvisfile#45

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@matthiasdiener matthiasdiener self-assigned this Jul 16, 2024
@matthiasdiener matthiasdiener marked this pull request as ready for review July 18, 2024 14:28
Copy link
Member

@MTCam MTCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕷️

@matthiasdiener matthiasdiener enabled auto-merge (squash) July 20, 2024 03:26
@matthiasdiener matthiasdiener merged commit 8d5e3eb into main Jul 20, 2024
12 of 13 checks passed
@matthiasdiener matthiasdiener deleted the pyvisfile-editable branch July 20, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants