Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stash time in the fluid state? #664

Open
MTCam opened this issue May 10, 2022 · 4 comments
Open

Stash time in the fluid state? #664

MTCam opened this issue May 10, 2022 · 4 comments

Comments

@MTCam
Copy link
Member

MTCam commented May 10, 2022

This is a feature request suggestion, mostly to see if it is laughed out of the room.

Can we stash time somewhere in the fluid state? That'd be great? 🤔

Originally posted by @MTCam in #648 (comment)

@majosm
Copy link
Collaborator

majosm commented May 10, 2022

One alternative would be to define the BCs inside the RHS. Then you wouldn't need to pass the time through the operators, you could just evaluate the boundary solutions at the current time and set up the BCs accordingly before passing them in.

@inducer
Copy link
Contributor

inducer commented May 10, 2022

@majosm beat me to suggesting that. :)

@MTCam
Copy link
Member Author

MTCam commented May 10, 2022

I think I'm unclear on the details of how that would work. Wouldn't that get a a re-compile at every substep?

@inducer
Copy link
Contributor

inducer commented May 10, 2022

No, I don't think so. Time comes into the RHS as a placeholder for an argument. You partial that into the relevant BC functions and pass those into the operators. Nothing should trigger a recompile there IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants