Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename use_serde feature? #216

Closed
iliekturtles opened this issue Oct 30, 2020 · 6 comments · Fixed by #436
Closed

Rename use_serde feature? #216

iliekturtles opened this issue Oct 30, 2020 · 6 comments · Fixed by #436

Comments

@iliekturtles
Copy link
Owner

This would be a breaking change. See https://blog.turbo.fish/cargo-features/ for details how to enable this. I'm partial to the idea of a better feature name and uom is not yet committed to backwards compatibility, but this may end up being a larger hassle for users that it's worth.

@Aehmlo
Copy link
Contributor

Aehmlo commented Oct 30, 2020

Is there any reason uom couldn't support both feature names? Then there could potentially be a soft-deprecation for the time being.

@iliekturtles
Copy link
Owner Author

Both could definitely exist and we could probably add a warning that use_serde is being used instead of serde.

@iliekturtles
Copy link
Owner Author

uom/src/tests/system.rs

Lines 540 to 543 in a77ef61

#[cfg(feature = "serde")]
quickcheck! {
// These serde tests can't be run against num-backed numeric backends because the
// num crate hasn't been updated to Serde 1.0 yet.

Num crates use Serde 1.0 now. It also looks like all of the uom internal code checks for the "serde" feature which doesn't actually exist!

@therealfrauholle
Copy link
Contributor

As far as I understand, with the introduction of namespaced features and weak dependencies as of rust-lang/cargo#10269 it is now much easier to implement and does not require re-exports as of the mentioned blog post. This feature moved to stable as of rust 1.60.0

So if the plan is ever to bump the MSRV, I guess it is time for deprecation now.

@iliekturtles
Copy link
Owner Author

iliekturtles commented Oct 24, 2022

I'm interested in bumping the MSRV (#239) but I'm a bit hesitant to go all the way to 1.60 when the work-arounds to resolve this issue aren't too painful and allow for an older MSRV. I don't have a specific policy about when to update the MSRV and what version to jump to so I'm interested in hearing thoughts about going all the way to 1.60.

EDIT: Just caught up with #387, lets discuss there.

@iliekturtles
Copy link
Owner Author

MSRV bumped to 1.60.0 in #422. I haven't started looking at this issue yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants