Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Signup Page #5

Open
batflarrow opened this issue Oct 1, 2021 · 18 comments
Open

Make Signup Page #5

batflarrow opened this issue Oct 1, 2021 · 18 comments
Labels
contribute-a-thon Participating issue in Contribute-a-thon good first issue Good for newcomers hacktoberfest Participating in Hacktoberfest

Comments

@batflarrow
Copy link
Contributor

No description provided.

@batflarrow batflarrow added contribute-a-thon Participating issue in Contribute-a-thon good first issue Good for newcomers hacktoberfest Participating in Hacktoberfest labels Oct 1, 2021
@orama254
Copy link

orama254 commented Oct 1, 2021

Greetings @batflarrow ,
For the signup page is it ok to change the folder structure?

@batflarrow
Copy link
Contributor Author

Greetings @batflarrow , For the signup page is it ok to change the folder structure?

Yeah sure you can create folders of components and containers and work accordingly.

@orama254
Copy link

orama254 commented Oct 1, 2021

Greetings @batflarrow , For the signup page is it ok to change the folder structure?

Yeah sure you can create folders of components and containers and work accordingly.

Awesome, can I be assigned this and work on it?

@batflarrow
Copy link
Contributor Author

Greetings @batflarrow , For the signup page is it ok to change the folder structure?

Yeah sure you can create folders of components and containers and work accordingly.

Awesome, can I be assigned this and work on it?

Yeah sure you have now been assigned.

@batflarrow
Copy link
Contributor Author

batflarrow commented Oct 5, 2021

Any updates @orama254 ...?

@orama254
Copy link

orama254 commented Oct 5, 2021

Any updates @orama254 ...?

Was thinking about starting with the folder structure first before creating the Signup Page @batflarrow

@batflarrow
Copy link
Contributor Author

Any updates @orama254 ...?

Was thinking about starting with the folder structure first before creating the Signup Page @batflarrow

As I suggested there will be two folders Components and Containers Entire SIgnup page will be placed in the Containers folder under Containers folder and the various components for the page will be placed in the components folder under the Signup folder.

@orama254
Copy link

orama254 commented Oct 5, 2021

Any updates @orama254 ...?

Was thinking about starting with the folder structure first before creating the Signup Page @batflarrow

As I suggested there will be two folders Components and Containers Entire SIgnup page will be placed in the Containers folder under Containers folder and the various components for the page will be placed in the components folder under the Signup folder.

Okay, maybe I can create a PR with the suggested folder structure first then you can review it before creating the signup page. Would that be ok?

@batflarrow
Copy link
Contributor Author

Any updates @orama254 ...?

Was thinking about starting with the folder structure first before creating the Signup Page @batflarrow

As I suggested there will be two folders Components and Containers Entire SIgnup page will be placed in the Containers folder under Containers folder and the various components for the page will be placed in the components folder under the Signup folder.

Okay, maybe I can create a PR with the suggested folder structure first then you can review it before creating the signup page. Would that be ok?

Yeah ok I won't merge it but if you want you can make a pr and then update the signup page in that branch itself.

@orama254
Copy link

orama254 commented Oct 5, 2021

Any updates @orama254 ...?

Was thinking about starting with the folder structure first before creating the Signup Page @batflarrow

As I suggested there will be two folders Components and Containers Entire SIgnup page will be placed in the Containers folder under Containers folder and the various components for the page will be placed in the components folder under the Signup folder.

Okay, maybe I can create a PR with the suggested folder structure first then you can review it before creating the signup page. Would that be ok?

Yeah ok I won't merge it but if you want you can make a pr and then update the signup page in that branch itself.

you can look at the suggestion on PR #8 to see if it comes close to the suggestion

@batflarrow
Copy link
Contributor Author

Any updates @orama254 ...?

Was thinking about starting with the folder structure first before creating the Signup Page @batflarrow

As I suggested there will be two folders Components and Containers Entire SIgnup page will be placed in the Containers folder under Containers folder and the various components for the page will be placed in the components folder under the Signup folder.

Okay, maybe I can create a PR with the suggested folder structure first then you can review it before creating the signup page. Would that be ok?

Yeah ok I won't merge it but if you want you can make a pr and then update the signup page in that branch itself.

you can look at the suggestion on PR #8 to see if it comes close to the suggestion

Yeah sure the folder structure is fine you may move ahead with the task.

@orama254
Copy link

orama254 commented Oct 6, 2021

hey @batflarrow

wanted to know which font was used on the design

screenshot:

ctf font

@poojavirgo
Copy link

@batflarrow can you please assign this issue to me?

@batflarrow
Copy link
Contributor Author

hey @batflarrow

wanted to know which font was used on the design

screenshot:

ctf font

It is present in the figma design :)

@batflarrow
Copy link
Contributor Author

hey @batflarrow
wanted to know which font was used on the design

screenshot:

ctf font

It is present in the figma design :)

Also @orama254 You have until the end of today to complete this issue or else you will be unassigned.

@batflarrow
Copy link
Contributor Author

@batflarrow can you please assign this issue to me?

If the current assignee is not able to complete then sure I'll assign it to you.

@poojavirgo
Copy link

poojavirgo commented Oct 6, 2021 via email

@orama254
Copy link

orama254 commented Oct 6, 2021

hey @batflarrow
wanted to know which font was used on the design

screenshot:

ctf font

It is present in the figma design :)

Also @orama254 You have until the end of today to complete this issue or else you will be unassigned.

hey @batflarrow unfortunately I wont be able to accomplish this by the end of the day. You can assign @poojavirgo the task

I'll try and contribute later on other issues/features of the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute-a-thon Participating issue in Contribute-a-thon good first issue Good for newcomers hacktoberfest Participating in Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants