Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated source file by EUROSTAT #38

Open
danielhuppmann opened this issue Oct 11, 2024 · 1 comment
Open

Updated source file by EUROSTAT #38

danielhuppmann opened this issue Oct 11, 2024 · 1 comment
Assignees

Comments

@danielhuppmann
Copy link
Member

Looks like Eurostat silently updated the NUTS xlsx file, the hash is now different - and unit tests in other repositories are failing because of it...

https://github.com/IAMconsortium/legacy-definitions/actions/runs/11296344229/job/31421010160?pr=18

The feature with downloading the xlsx from Eurostat is nice, but risky if this happens from time to time without any announcement or quick solution for downstream users.

Maybe instead keeping a json or yaml of the relevant data in the repo is a more stable solution, like https://github.com/pycountry/pycountry/tree/main/src/pycountry/databases?

@danielhuppmann
Copy link
Member Author

Thinking about this further, I think a good solution would be the following:

  • include the NUTS classification info as a hard-coded yaml in this repository
    (and make a release to solve downstream problems)
  • move the tool to parse the Eurostat file (and create that yaml file) to a utility function in this package
  • add a weekly GitHub workflow that checks whether the hash of the Eurostat file changed, so that we get an alert when Eurostat updates the file - so that we can check whether the actual NUTS codes/names changed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants